'Your changes will not be saved' alert window when trying to reload a web page

[SkorikSergey]

Describe the bug

'Your changes will not be saved' alert window when trying to reload web page. The cause of this issue are https://github.com/eclipse/che-theia/pull/634 changes

Che version

• [ ] latest
• [x] nightly
• [ ] other: please specify

Steps to reproduce

1. Start workspace from any devfile.
2. Try to reload web page.

Expected behavior

The page was reloaded

Runtime

• [ ] kubernetes (include output of kubectl version)
• [x] Openshift (include output of oc version)
• [ ] minikube (include output of minikube version and kubectl version)
• [ ] minishift (include output of minishift version and oc version)
• [ ] docker-desktop + K8S (include output of docker version and kubectl version)
• [ ] other: (please specify)

Screenshots

Installation method

• [ ] chectl
• [x] che-operator
• [ ] minishift-addon
• [ ] I don't know

Environment

• [ ] my computer
  • [ ] Windows
  • [x] Linux
  • [ ] macOS
• [ ] Cloud
  • [ ] Amazon
  • [ ] Azure
  • [ ] GCE
  • [ ] other (please specify)
• [ ] other: please specify

[rhopp]

@SkorikSergey This is not a bug and the tests needs to be adapted, right?

[vzhukovs]

@rhopp yes, seems, that tests have to be aligned to the new behavior.

[vzhukovs]

@SkorikSergey another question, is this a manual testing scenario?

As far as I saw, Happy Path scenario passed successfully:

[SkorikSergey]

HappyPath doesn't reload page. There is tests result with failed tests - https://ci.codenvycorp.com/view/qa-nightly/job/che-integration-tests-multiuser-master-ocp/946/Selenium_20tests_20report/.

[rhopp]

@vzhukovskii This failure is happenig in the legacy java-selenium suite. We still have some tests there... They run as PR check on eclipse/che repo and right now, they are kind of "hidden" - We have a task in the current sprint to improve the reporting from this job.

[SkorikSergey]

This issue (https://github.com/eclipse/che/issues/13580) is about closing only terminal tab not browser tab. For now if type Ctrl + w in terminal and click Leave button browser tab will be closed.

[vzhukovs]

Theia handles Cmd/Ctrl+W only for tab close, we can't modify this behavior for handling only some part, e.g. terminal tab, or editor tab. We just can intercept this hotkey and prevent browser tab closing. (As this hotkey is reserved in browsers). So that's why there was added overridden configuration item to preferences that asks user whether he wants to close tab or not.

This issue (#13580) is about closing only terminal tab not browser tab.

Expected: Ideal behavior would be the same as in native terminal - last word is erased, but I afraid whether it is possible to override such browser hotkey. So, at least a confirmation dialog should be shown before closing, because it's a typical thing when user press ctrl+w in terminal and does not to close tab.

[rhopp]

IMHO this behavior change is "UX downgrade". In my opinion, the confirmation should appear only when data loss is at place (aka. some editor is not saved).

Anyway... Until this gets sorted, @SkorikSergey we can put back the previous behavior by setting this in user preferences before actually running the test (the same way, that @Ohrimenko1988 is doing this for example for setting the terminal type to dom)

[Katka92]

This issue is a root cause of failures for nightly tests with the nightly image. I assume @SkorikSergey is fixing that in Java tests, so I will do that for typescript ones.

[amisevsk]

@rhopp As a user of Che, "ctrl-w to close your whole IDE" was maybe my least favorite thing about Theia :). When typing in a terminal, ctrl-w is one of the hardest habits to break.