Closed nickboldt closed 4 years ago
I have marked this blocker until we figure out how we can inject this into the rhel8-based endpoint runtime image, or decide that along with the theia-dev-rhel8
container, we need an actual new image to be published via Comet to RHCC.
not a blocker for Che it works perfectly
As I said, I was marking it a blocker because I need help determining how to proceed w/ downstreaming this. You've effectively prevented che-theia from being built in a pure rhel-based approach, which while not a blocker for Che or Hosted Che, is certainly a regression from how things were in 7.9 and 7.10.
fixed
In Che 7.11, this change happened in the endpoint runtime build:
-- https://github.com/eclipse/che-theia/commit/06ef7ee00cbb4724c0541e232a11418e0559e35a
So now, even though the che-theia build is theoretically able to run against alpine OR ubi, it has a hard dependency on https://github.com/che-dockerfiles/che-custom-nodejs-deasync/blob/master/Dockerfile which of course has no rhel/ubi analogue.
The result is that the crw theia-endpoint-rhel8 container cannot be built in Brew because:
This means we either need to
quay.io/eclipse/che-custom-nodejs-deasync
This is feature something that we really need in Che, and if so, is there any other way to build it into the endpoint runtime binary?