search

eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

tekton sidecar: missing octant daemon autostart and allowed hosts ENV var. #17769

Open gattytto opened 4 years ago

gattytto commented 4 years ago

octant requires an ENV VAR in the sidecar with a list of allowed hosts and the octant (web ui) daemon is not started automatically inside the tekton sidecar.

it is possible to set a wildcard to the octant allowed hosts. https://github.com/vmware-tanzu/octant/issues/199#issuecomment-523563021

should the daemon be autostarted in the entrypoint.sh?.

ericwill commented 4 years ago

should the daemon be autostarted in the entrypoint.sh?.

Can't it be auto-started as part of the container setup?

gattytto commented 4 years ago

@ericwill what I mean is, it's not "needed", only when the octant UI wants to be used.

gattytto commented 4 years ago

OCTANT_ACCEPTED_HOSTS env var should be set to 0.0.0.0

gattytto commented 4 years ago

I think it would be better set as "command" in tekton's plugin meta.yaml 

commands:          # development commands available to plugin container
        - name:
          runOctant:
          command:       # list of commands + arguments, e.g.:
            - octant
            - -p or whatever --port arg
che-bot commented 3 years ago

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

gattytto commented 3 years ago

I may retake this one from here