Closed monaka closed 2 years ago
cc: dashboard @sleshchenko, che-thea @azatsarynnyy WDYT?
Hello @monaka it would be cool to see such a contribution. Do you plan to work on PWA for both clients: Dashboard and Che Theia? If for both, will it require some work in upstream Theia or in Che Theia only?
Currently the code is in Dashboard. (And is copied into the che-server image). https://github.com/PizzaFactory/che-dashboard/tree/937317a/wpa-resources The status is "experimental". I'm not sure if this approach is best.
@monaka Are you planning to continue on this one?
I think a single PWA on dashboard level is OK but we need to implement a good caching strategy for Theia editor, there is a lot of gains that can be achieved with that.
@gorkem Currently, the implementation has been postponed.
I agree the caching for Theia is challenging.
And I suppose that just even adding mainfest.json
and icons will improve the user experience.
Issues go stale after 180
days of inactivity. lifecycle/stale
issues rot after an additional 7
days of inactivity and eventually close.
Mark the issue as fresh with /remove-lifecycle stale
in a new comment.
If this issue is safe to close now please do so.
Moderators: Add lifecycle/frozen
label to avoid stale mode.
Droppped dashboard part since I believe it's already done with https://github.com/eclipse-che/che-dashboard/pull/323
Issues go stale after 180
days of inactivity. lifecycle/stale
issues rot after an additional 7
days of inactivity and eventually close.
Mark the issue as fresh with /remove-lifecycle stale
in a new comment.
If this issue is safe to close now please do so.
Moderators: Add lifecycle/frozen
label to avoid stale mode.
Is your enhancement related to a problem? Please describe.
Some browers hook some keybinds (like Ctrl-N) before handling by Che.
Describe the solution you'd like
Adding content for PWA and making it as an application.
Describe alternatives you've considered
Publishing webview application for clients.
Additional context
PizzaFactory (Che fork) has already started the basic PWA support. Cache and offline support are WIP. I'll contribute later (may be within this Christmas holiday).