eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.95k stars 1.19k forks source link

Why are happy path tests not running maven compile-time tests? #19115

Closed nickboldt closed 2 years ago

nickboldt commented 3 years ago

I discovered today that the dashboard-next-happy-path tests are not running the maven tests:

-DskipTests -Dskip-enforce -Dskip-validate-sources

-- https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/rest/organizations/jenkins/pipelines/dashboard-next-happy-path/runs/377/nodes/41/steps/93/log/?start=0

Granted, they're being run elsewhere for nightly and release bulds...

But would it make sense to run them here too?

benoitf commented 3 years ago

Usually happy path test is taking a long time (build, spin up minikube, deploy che, etc), so we remove all checks of the build to test the build as soon as possible. And other jobs ensure that the build/unit tests are passing Also github action job maven build is mandatory to merge So, I don't see any issue there.

che-bot commented 3 years ago

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.