search

eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.94k stars 1.18k forks source link

Add unit tests in devworkspace-client #19150

Closed benoitf closed 2 years ago

benoitf commented 3 years ago

Is your enhancement related to a problem? Please describe.

When doing the implementation in che-theia I added jest tests by mocking kubernetes-client's call and I think it would improve the quality of this library if unit tests are handled as well there.

Describe the solution you'd like

jest/mock data of the real k8s platform

Describe alternatives you've considered

N/A

Additional context

JPinkney commented 3 years ago

@benoitf Can you link to where you had this implemented in che-theia

benoitf commented 3 years ago

@JPinkney https://github.com/eclipse/che-theia/tree/master/extensions/eclipse-che-theia-remote-impl-k8s/tests

che-bot commented 2 years ago

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

sleshchenko commented 2 years ago

devworkspace-client does not exist ATM. closing this issue