Mark CheCluster API v1 as unserved version

tolusha commented 2 years ago

Is your task related to a problem? Please describe

We still support CheCluster API v1 after introducing v2. It imposes additional difficulties with extending v2 since we have to add the similar fields to v1 and implement conversion.

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

https://github.com/eclipse/che/issues/21579

Divine1 commented 2 years ago

@tolusha

a quick question,

i'm using chectl/0.0.20220725-next.71d60f1 darwin-x64 node-v16.13.2

below is my checluster. is this checluster v2 or v1? does the generation attribute indicates the version of checluster?

kubectl get checluster -n eclipse-che -o yaml

apiVersion: v1
items:
- apiVersion: org.eclipse.che/v2
  kind: CheCluster
  metadata:
    creationTimestamp: "2022-07-26T07:51:46Z"
    finalizers:
    - checluster.che.eclipse.org
    - cheGateway.clusterpermissions.finalizers.che.eclipse.org
    - cheWorkspaces.clusterpermissions.finalizers.che.eclipse.org
    - namespaces-editor.permissions.finalizers.che.eclipse.org
    - devWorkspace.permissions.finalizers.che.eclipse.org
    - dashboard.clusterpermissions.finalizers.che.eclipse.org
    generation: 2
    name: eclipse-che
    namespace: eclipse-che
    resourceVersion: "18171927"
    uid: 7b18d837-0c45-45c9-953c-0d1bb4806f85
  spec:
    components:
      cheServer:
        debug: true
        extraProperties:
          CHE_INFRA_KUBERNETES_PVC_QUANTITY: 5Gi
          CHE_INFRA_KUBERNETES_WORKSPACE__START__TIMEOUT__MIN: "15"
        logLevel: INFO
      dashboard: {}
      database:
        credentialsSecretName: postgres-credentials
        externalDb: true
        postgresDb: dbche
        postgresHostName: sc2-10-186-67-195.eng.vmware.com
        postgresPort: "5432"
        pvc:
          claimSize: 1Gi
      devWorkspace: {}
      devfileRegistry: {}
      imagePuller:
        enable: false
        spec: {}
      metrics:
        enable: true
      pluginRegistry: {}
    containerRegistry: {}
    devEnvironments:
      defaultNamespace:
        template: <username>-che
      secondsOfInactivityBeforeIdling: 1800
      secondsOfRunBeforeIdling: -1
      storage:
        pvcStrategy: common
    networking:
      auth:
        gateway:
          configLabels:
            app: che
            component: che-gateway-config
        identityProviderURL: https://dex-dchelladurai-chejune15.calatrava.vmware.com
        oAuthClientName: eclipse-che
        oAuthSecret: ZXhhbXBsZS1hcHAtc2VjcmV0
      domain: eclipseche-dchelladurai-chejune15.calatrava.vmware.com
      tlsSecretName: che-tls
  status:
    chePhase: Active
    cheURL: https://eclipseche-dchelladurai-chejune15.calatrava.vmware.com
    cheVersion: next
    devfileRegistryURL: https://eclipseche-dchelladurai-chejune15.calatrava.vmware.com/devfile-registry
    gatewayPhase: Established
    pluginRegistryURL: https://eclipseche-dchelladurai-chejune15.calatrava.vmware.com/plugin-registry/v3
    workspaceBaseDomain: eclipseche-dchelladurai-chejune15.calatrava.vmware.com
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

tolusha commented 2 years ago

Hello @Divine1 It is v2 because of apiVersion: org.eclipse.che/v2

ibuziuk commented 2 years ago

@tolusha please do not fully remove v1 untill the dashboard is updated accordingly https://github.com/eclipse/che/issues/21594 cc: @olexii4 @akurinnoy

tolusha commented 2 years ago

I tried to mark CheCluster API V1 as unserved but got the following error on the OpenShift:

  requirementStatus:
    - group: apiextensions.k8s.io
      kind: CustomResourceDefinition
      message: CRD is not present
      name: checlusters.org.eclipse.che
      status: NotPresent
      version: v1

https://github.com/operator-framework/operator-lifecycle-manager/issues/2866

che-bot commented 1 year ago

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

eclipse-che / che