eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

Add missing recommended extensions to .vscode/extensions.json in all che-samples #21644

Closed vitaliy-guliy closed 2 years ago

vitaliy-guliy commented 2 years ago

Is your enhancement related to a problem? Please describe

I noticed, that not all the plugins appeared to be installed after creating a workspace from quarkus sample.

.vscode/extensions.json for quarkus sample contains only one redhat.vscode-quarkus recommendation. Che-Theia performs the plugin installation properly. It opens redhat/vscode-quarkus/latest/che-theia-plugin.yaml, downloads all the extensions from extensions: block and does the same for all the dependencies from dependencies:.

When che-code handles .vscode/extensions.json file, it does not aware about redhat/vscode-quarkus/latest/che-theia-plugin.yaml and does not install dependencies, that are described in dependencies: block

dependencies:
  - redhat/java
  - redhat/vscode-microprofile
  - vscjava/vscode-java-debug
  - vscjava/vscode-java-test

This is what I have after installing the recommendations for quarkus

Screenshot from 2022-08-19 17-35-42

Che-code does not touch redhat/vscode-quarkus/latest/che-theia-plugin.yaml, but installs all the dependencies, that are described in package.json of quarkus plugin.

  "extensionDependencies": [
    "redhat.vscode-microprofile",
    "redhat.java",
    "vscjava.vscode-java-debug",
    "vscode.html-language-features"
  ],

Describe the solution you'd like

Review all che-samples, that we use for workspace creation, and add missing extensions to .vscode/extensions.json

Describe alternatives you've considered

No response

Additional context

No response

vitaliy-guliy commented 2 years ago

Pull Requests to merge:

svor commented 2 years ago

downstream issue: https://issues.redhat.com/browse/CRW-3302