eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.96k stars 1.19k forks source link

Update Traefik to 2.9.6 version #21869

Closed framar89 closed 1 year ago

framar89 commented 1 year ago

Summary

Currently the default image version used for traefik is quay.io/eclipse/che--traefik:v2.8.1-4e52a5e2495484f5e19a49edfd2f652b0bce7b3603fa0df545ed90168ffae1c3 which has a critical vulnerability as showed in https://quay.io/repository/eclipse/che--traefik?tab=tags I ran a security scan using Trivy (https://trivy.dev/results/?image=traefik:v2.8.2) for the Dockerhub image traefik:v2.8.2 and it tells that there are no vulnerabilities.

So my questions are:

Thanks

Relevant information

No response

tolusha commented 1 year ago

@framar89

  1. Yes, it can be updated.
  2. You can try traefik:v2.8.2 image without any changes and it must be compatible. If it works for you, I will create a PR. Use the following command to set a new image in CheCluster CR
    kubectl patch checluster/eclipse-che --patch '{"spec": {"networking": {"auth": {"gateway": {"deployment": {"containers": [{"name": "gateway", "image": "traefik:v2.8.2"}]}}}}}}' --type=merge -n eclipse-che
  3. There can't be any differences, quay.io contains a copy of docker.io image.
framar89 commented 1 year ago

Unfortunately traefik:v2.8.2 does not work but I tried traefik:v2.9.5 (released 20 days ago) and it worked.

So, I think you can update to v2.9.5.

tolusha commented 1 year ago

traefik:v2.8.2 does not work for me either. The latest greatest traefik:v2.9.6 works fine for me. I will open a PR to switch to the new image.

nickboldt commented 1 year ago

Upstream steps (for 7.59):

Downstream steps (for 3.5 - https://issues.redhat.com/browse/CRW-3606):