eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

To start JetBrains IDEs, use `post-start` rather than overrideing the entrypoint #22034

Closed l0rd closed 1 year ago

l0rd commented 1 year ago

Is your enhancement related to a problem? Please describe

The editor command overrides the tooling container entrypoint:

This blocks services as kubedock (to support docker run) to be run at startup in tooling containers.

Describe the solution you'd like

The solution is the same as the one provided for VS Code, remove the command in the editor container and a an init-che-code-command among the devfile commands associated to a post-start event:

(...)
  commands:
      - id: init-che-code-command
        exec:
          component: che-code-runtime-description
          commandLine: 'nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &'
  events:
      postStart:
        - init-che-code-command
devstudio-release commented 1 year ago

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-4155