eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.96k stars 1.19k forks source link

Che Cluster Networking annotations only apply to ingresses, not routes #23118

Open AObuchow opened 2 weeks ago

AObuchow commented 2 weeks ago

Describe the bug

In the Che Cluster CR, there's a field for setting annotations to be applied to the ingresses and routes created for workspaces:

    // Defines annotations which will be set for an Ingress (a route for OpenShift platform).
    // The defaults for kubernetes platforms are:
    //     kubernetes.io/ingress.class:                       "nginx"
    //     nginx.ingress.kubernetes.io/proxy-read-timeout:    "3600",
    //     nginx.ingress.kubernetes.io/proxy-connect-timeout: "3600",
    //     nginx.ingress.kubernetes.io/ssl-redirect:          "true"
    // +optional
    Annotations map[string]string `json:"annotations,omitempty"`

However, in the Che router implementation, these annotations are only applied to ingresses, not routes.

Che version

7.90@latest

Steps to reproduce

  1. Configure networking.annotations in the Che Cluster CR to have a custom annotation, e.g. my-test-annotation: test-annotation-value
  2. Create a workspace (e.g. the empty workspace sample)
  3. Check the routes created for your workspace and see the custom annotations set in the Che Cluster CR is missing.

Expected behavior

The annotations from networking.annotations in the Che Cluster CR are applied to the routes created for a workspace.

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

AObuchow commented 2 weeks ago

It might be that this is simply an error in the Che Cluster CR's documentation. Maybe it is intended for the networking annotations to only get applied to Ingresses and not Routes.