eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

[Test] Fix Dev Spaces "User secrets in workspace" test to avoid using an absolute devfile registry #23203

Closed SkorikSergey closed 1 month ago

SkorikSergey commented 1 month ago

What does this PR do?

Create new checkUserEnvsTest test that will check ``` "````````User secrets in workspace" test-case

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7271

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

dmytro-ndp commented 1 month ago

@SkorikSergey : CheckUserEnvsTest.spec.ts test name is too vague, IMHO. What do you think about naming the test more straightforward, like: UserSecretsInWorkspace.spec.ts?

SkorikSergey commented 1 month ago

@SkorikSergey : CheckUserEnvsTest.spec.ts test name is too vague, IMHO. What do you think about naming the test more straightforward, like: UserSecretsInWorkspace.spec.ts?

Yes, that is better. I will rename it to UserSecretsInWorkspaceTest

dmytro-ndp commented 1 month ago

@SkorikSergey : Test prefix in a script name is redundant. Look at the other test script names in the specs folder.

SkorikSergey commented 1 month ago

@SkorikSergey : Test prefix in a script name is redundant. Look at the other test script names in the specs folder.

Ok. Updated.