eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

Apply linter suggestions #23215

Closed musienko-maxim closed 3 weeks ago

musienko-maxim commented 3 weeks ago

What does this PR do?

Screenshot/screencast of this PR

e2e-che-lint

What issues does this PR fix or reference?

How to test this PR?

Just run npm run eslint --fix . command in the catalog with tests

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

dmytro-ndp commented 3 weeks ago

@musienko-maxim : what do you think about adding lint error verification to the EmptyWorkspace PR check https://github.com/eclipse-che/che/blob/main/.github/workflows/pr-check.yml#L96 ?

dmytro-ndp commented 3 weeks ago

FYI: @SkorikSergey has already fixed lint error by another PR https://github.com/eclipse-che/che/pull/23216

musienko-maxim commented 3 weeks ago

@musienko-maxim : what do you think about adding lint error verification to the EmptyWorkspace PR check https://github.com/eclipse-che/che/blob/main/.github/workflows/pr-check.yml#L96 ?

+1 I am preparing an issue