search

eclipse-che4z / che-che4z-lsp-for-cobol

COBOL Language Support provides autocomplete, highlighting and diagnostics for COBOL code and copybooks
Other
79 stars 55 forks source link

Inconsistent syntax highlighting in light theme #2430

Open FilipDrabek-Broadcom opened 1 month ago

FilipDrabek-Broadcom commented 1 month ago

Syntax highlighting is inconsistent when changing (from dark theme) to light theme. image The brackets are no longer yellow color in light theme.

ap891843 commented 1 month ago

I did see similar behavior for other languages as well (for e.g. JS). Which makes me believe it might be related to theme. This could be something to investigate.

image image

FilipDrabek-Broadcom commented 1 month ago

I just checked it myself and it looks like the color of the brackets is still slightly different to the color of the "name". Although from the user experience perspective, I would expect totally different color (as is case with Dark Theme). image image

Difference in hues. image

But in our case the colors are either the same or almost indistinguishable. image

Difference in hues. image

FilipDrabek-Broadcom commented 3 weeks ago

Again, I think we should stay consistent with VS Code standard.

Please use colors as per the "javascript" example. image image

Unfortunately I don't have the CSS file, so I don't know the exact HEX value, but the colors should look like these two hues. image