eclipse-cyclonedds / cyclonedds-insight

Other
10 stars 6 forks source link

show QoS incompatibilities in the systems #3

Closed trittsv closed 1 month ago

trittsv commented 7 months ago

The tool shall display warnings on reader/writer and topic where the QoS are not compatible.

trittsv commented 7 months ago

@eboasson i wanted to start working on this, so that we are on the same page, the QoS are described in 2.2.3 in the document https://www.omg.org/spec/DDS/1.4/PDF ? Or is there anywhere a better non-textual description?

eboasson commented 7 months ago

That would be the official list. You could also look at https://github.com/eclipse-cyclonedds/cyclonedds/blob/6498bf992059d3f491f5b351da8c7f0eb15f04a7/src/core/ddsi/src/ddsi_qosmatch.c#L131, which implements the checks and has the advantages of being the code that Cyclone actually uses and of being more compact than the spec representation.

There is also https://github.com/eclipse-cyclonedds/cyclonedds/blob/6498bf992059d3f491f5b351da8c7f0eb15f04a7/src/core/ddsc/tests/qos_set_match.c#L500 (since a few hours ago) 🙂

That one also got double-checked against the spec.