search

eclipse-cyclonedds / cyclonedds-python

Other
54 stars 44 forks source link

Fix struct inheritance #164

Closed thijsmie closed 1 year ago

thijsmie commented 1 year ago

This fixes #162 and some related issues around struct inheritance. @jordialexalar will you please test if this fixes your issue?

jordialexalar commented 1 year ago

Hi Thijs,

Thanks for your answer. After testing the changes you made, I can say that inheritance works properly, like for example in your file tests/test_struct_inheritance.py https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164/files#diff-bdd22c79cf592e46ebb88c7aabe75bc97f7eff3162a06f48bcbf764e5d05d890 but when we use inheritance in our examples of conexion , with file publisher.py and subscriber.py, another error arises. If attached in this e-mail the files of the example and another word file with the error that appears when the subscriber.py file is executed. Perhaps you can help us with the problem.

Thanks for all

Jorge Alejandre

El vie, 11 nov 2022 a las 10:28, Thijs Miedema @.***>) escribió:

This fixes #162 https://github.com/eclipse-cyclonedds/cyclonedds-python/issues/162 and some related issues around struct inheritance. @jordialexalar https://github.com/jordialexalar will you please test if this fixes your issue?

You can view, comment on, or merge this pull request online at:

https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164 Commit Summary

File Changes

(7 files https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164/files)

Patch Links:

- https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164.patch

— Reply to this email directly, view it on GitHub https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAY2RKZSTGOLDM3MFF4EMLWHYGVDANCNFSM6AAAAAAR5NI4HU . You are receiving this because you were mentioned.Message ID: @.***>

thijsmie commented 1 year ago

Hi @jordialexalar,

Could you send the files you mentioned here or to my email opensource at tmiedema.com, attaching them to the comment email doesn't seem to have worked.

thijsmie commented 1 year ago

Hi @jordialexalar,

Thank you for your reproducer, it helped me track down a subtle way it could still go wrong. With this extra one-line change your example now works for me.

jordialexalar commented 1 year ago

Hi Thijs,

Thanks for your answer.

After testing the changes you have made, I've just tried them,and as you say now it works fine.

Thanks for all

Jorge Alejandre

El lun, 21 nov 2022 a las 9:43, Thijs Miedema @.***>) escribió:

Hi @jordialexalar https://github.com/jordialexalar,

Thank you for your reproducer, it helped me track down a subtle way it could still go wrong. With this extra one-line change your example now works for me.

— Reply to this email directly, view it on GitHub https://github.com/eclipse-cyclonedds/cyclonedds-python/pull/164#issuecomment-1321701505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAY2RNVTNUWQUFBLLK6P63WJMY3JANCNFSM6AAAAAAR5NI4HU . You are receiving this because you were mentioned.Message ID: @.***>