eclipse-cyclonedds / cyclonedds-python

Other
54 stars 44 forks source link

Inheritance in cyclonedds-python not working properly after last commits in the master #172

Open Bit-Seq opened 1 year ago

Bit-Seq commented 1 year ago

Hello,

After downloading the master of cyclonedss and cyclonedds-python, and test structs' inheritance, subscriber is not receiving any message.

If you test with the next IDL:

module module_test {
    struct parent {
        char var;
    };
    struct child : parent {
        char var2;
    };
};

And subscriber tries to receive messages from parent, it works properly, but it is not able to receive messages from child.

It seems that the changes done by @thijsmie on issue #162 solved the problem, but commits from the last days have caused the problem.

Best regards.

Bit-Seq commented 1 year ago

Sorry, I had a configuration error in some tests from my battery. Issue closed.

thijsmie commented 1 year ago

Well actually there is an issue which I discovered due to looking into this! So I've added a test and fixed the fact that the structs base type was not included in the XTypes type information. The work in progress is here: https://github.com/thijsmie/cyclonedds-python/tree/172-struct-inheritance

We will merge once we've resolved some CI trouble and I've also fixed the fact that cyclonedds typeof doesn't properly support inheritance either.

Bit-Seq commented 1 year ago

If it helps, we downloaded the master branch from cyclonedss and cyclonedss-python on November 28th and 29th and structs inheritance was working correctly on our tests https://github.com/javiersorianoruiz/cyclonedds-python-checkReservedKeyword/tree/master/tests/ (007_test_X).