eclipse-cyclonedds / cyclonedds-python

Other
54 stars 44 forks source link

#187 Modified implementation to construct domain participants on the default domain #188

Closed gmartin82 closed 1 year ago

gmartin82 commented 1 year ago

Modified the implementation to construct domain participants on the default domain (as determined by the Cyclone DDS configuration) by default unless users provide a domain Id when constructing a domain participant.

The proposed solution could potentially affect existing applications as, depending on configuration, user applications may run by default on a domain other than 0 as they would have previously. However, this may actually be desirable. An alternative if this is problematic would be to add a classmethod to Domain to return the default domain Id constant in a similar way to the C++ binding.

I've also updated the examples and tooling to use the default domain by default.

I also found the async example wasn't working with the regular vehicle publisher. I've modified the implementation to ensure the examples are able to communicate as part of the testing.