search

eclipse-cyclonedds / cyclonedds

Eclipse Cyclone DDS project
https://projects.eclipse.org/projects/iot.cyclonedds
Other
887 stars 362 forks source link

Readme file : Conflict in version number of DDSI-RTPS #1860

Open Aman568 opened 1 year ago

Aman568 commented 1 year ago

Hi Everyone,

Readme file specify DDSI-RTPS protocol is based on version 2.5. However the Header file ddsi__protocol.h, DDSI-RTPS protocl is 2.1.

Hence is confusing Cyclone DDS is based DDSI-RTPS protocol 2.5 or 2.1.

Thank You BR, Aman

eboasson commented 11 months ago

Both are, to some extent, true. In DDSI 2.3, the OMG did a backwards-incompatible change, mandating the use of some messages that were previously required to be rejected. I originally put in the code to reject those messages and to have a complicated workaround, then removed it in baadb2b690607f9b3a606720d65e518a07e6fceb.

Since Cyclone now follows the new model, it should update the version number it gives in the protocol. Unfortunately that commit message says:

Note that full DDSI 2.3 compliance needs a bit more work, so not bumping the DDSI protocol version number yet.

I did keep an eye on the changes in the DDSI spec, it is all minor stuff, but before bumping the minor number in the sources the details need to be checked. After that, it will simply be DDSI 2.5, in docs and sources 🙂

Aman568 commented 11 months ago

Dear @eboasson,

Thank You for providing information.

Thank You BR, Aman

Aman568 commented 11 months ago

Dear @eboasson ,

Thank You for providing information. As per RTPS-2.5, Header extension to accommodate CRC of the RTPS message is added. Is this available in Cyclone DDS ?

Thank You BR, Aman

eboasson commented 11 months ago

Not yet. Do note that the message format is defined such that the header extension will be ignored by implementations that don't yet support it.