eclipse-cyclonedds / cyclonedds

Eclipse Cyclone DDS project
https://projects.eclipse.org/projects/iot.cyclonedds
Other
799 stars 349 forks source link

Some questions about "dds_stream_write_keyBE" #1958

Closed gongqinpeng closed 3 weeks ago

gongqinpeng commented 3 months ago

The 211 line of "dds_cdrstream.h" "dds_stream_write_keyBE" have five parameters, but in the 3983 line of "dds_cdrstream.c" have four parameters, I want to know why this is based on the big end and small end mentioned above, thank you very much!

eboasson commented 3 months ago

I think you've found a bug in code that exists for big-endian machines, and that doesn't get compiled on the CI or locally because big-endian machines are so rare these days (you're really looking at older Power(PC), SPARC and MIPS).

Fixing this one thing is easy enough, but who knows what else may have slipped through. Cross-compiling and qemu it is then ...

gongqinpeng commented 3 months ago

Okay thank you very much

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年4月2日(星期二) 下午5:20 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [eclipse-cyclonedds/cyclonedds] Some questions about "dds_stream_write_keyBE" (Issue #1958)

I think you've found a bug in code that exists for big-endian machines, and that doesn't get compiled on the CI or locally because big-endian machines are so rare these days (you're really looking at older Power(PC), SPARC and MIPS).

Fixing this one thing is easy enough, but who knows what else may have slipped through. Cross-compiling and qemu it is then ...

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>