B64 sysdef `_data` - Githubissues

eclipse-cyclonedds / cyclonedds

Eclipse Cyclone DDS project

https://projects.eclipse.org/projects/iot.cyclonedds

Other

854 stars 352 forks source link

B64 sysdef `_data` #1987

Closed Splinter1984 closed 4 months ago

Splinter1984 commented 5 months ago

According to DDS-XML spec. group/user/topic_data <value> element should be presented in Base64 format. With this PR:

decode b64 format data from xml configuration to dds_octetseq value before set.
update qos_provider test to encode tested qos group/user/topic_data before form xml-string.
remove wrong validation of history_kind.

[!WARNING] cxx binding qos_provider related tests will fail, and will be fixed by #PR488.

Splinter1984 commented 5 months ago

@eboasson, thank you for your review. cxx binding changes now available #PR488 and some minor additional changes have been made along with current PR.