eclipse-cyclonedds / cyclonedds

Eclipse Cyclone DDS project
https://projects.eclipse.org/projects/iot.cyclonedds
Other
854 stars 352 forks source link

Python lib determination is not platform independent #2050

Closed trittsv closed 4 days ago

trittsv commented 3 months ago

It uses python3 executable to determine the python libs, but on windows there is no python3.exe. The windows python3 installer creates only python.exe.

See here: https://github.com/eclipse-cyclonedds/cyclonedds/blob/d7db65c7f9def668af029890c351de6186977d58/src/tools/idlc/src/idlc/generator.c#L167

Of course a easy workaround is to duplicate the python.exe on windows and rename it to python3.exe ...

eboasson commented 3 months ago

What could go wrong if, on failure of the existing test, we simply tried again but using plain python? It would still need to have cyclonedds.__idlc__ available and so even if that causes it to start python 2 it seems to me it should be ok.