search

eclipse-cyclonedds / cyclonedds

Eclipse Cyclone DDS project
https://projects.eclipse.org/projects/iot.cyclonedds
Other
889 stars 363 forks source link

Allow colon and period in topic names #2089

Open a-zw opened 2 months ago

a-zw commented 2 months ago

Currently, topic names with colons or periods are not allowed.

The binding specified by Autosar requires those because it defines a naming scheme for topics like "ara.com://services//". See the AUTOSAR_AP_SWS_CommunicationManagement SWS_CM_1101 requirement.

a-zw commented 2 months ago

I'm confused about the versions. We use 0.10.4. On the master branch the issue seems already fixed via #1426 ?

dpotman commented 2 months ago

The 0.10.x branch was created before the commit in that PR was merged into master, which is why it isn't included in the 0.10.4 release (or any other 0.10.x release). We could backport this commit to 0.10.x, but since we're also working towards the 0.11 release, I'll need to check with @eboasson.

eboasson commented 3 weeks ago

I'm fine with backporting it. There is also #2119 that I think needs backporting, so I suspect there'll even be a 0.10.6 release.