search

eclipse-dali / webtools.dali

Eclipse Public License 2.0
2 stars 2 forks source link

Generate entities from database tables are failing for JPA 3.x #10

Open lak-proddev opened 1 month ago

lak-proddev commented 1 month ago

Generate entities from database tables are failing for JPA 3. x due to the package name changes. https://github.com/eclipse-dali/webtools.dali/issues/6#issuecomment-2107726547

In JPA 3.x the package name changed from "javax.persistence" to "jakarta.persistence". We need to make these changes in code generation.

nitind commented 1 month ago

It would be better to vary the package named used based on 1) the facet version, if present or 2) which version of the APIs are on the project build path, rather than a hard switchover to always using the Jakarta namespace.

lak-proddev commented 1 month ago

It would be better to vary the package named used based on 1) the facet version, if present or 2) which version of the APIs are on the project build path, rather than a hard switchover to always using the Jakarta namespace.

Agree. That's the reason for delaying the fix. Otherwise, it's just a simple constant value change.

nitind commented 3 weeks ago

@lak-proddev 3.34 is tagged, I'll soon be switching our builds over to 3.35.