eclipse-dataspace-dcp / decentralized-claims-protocol

This repository contains normative documents defining protocols and flows of the Eclipse Decentralized Claims Protocol (DCP)
https://eclipse-dataspace-dcp.github.io/decentralized-claims-protocol/
Apache License 2.0
10 stars 13 forks source link

Remove `@context` property from CredentialObject examples #90

Open arnoweiss opened 2 weeks ago

arnoweiss commented 2 weeks ago

What's wrong?

The CredentialObject example has an @context object that contains prefix-definition.

Why is this a bug?

The CredentialObject is always embedded in the issuerMetadata or CredentialOfferMessage payloads, both of which always have a mandatory @context property. While the schemas would allow for an embedded context, the spec shouldn't encourage it.

How could it be fixed?

Remove property from example

More context

Came up in the review of https://github.com/eclipse-dataspace-dcp/decentralized-claims-protocol/pull/89

arnoweiss commented 1 week ago

102 complicated this even more as the property is now normative in the markdown file but not in the json-schema. Approach: