Auto approve action incorrectly marking files as public API.

eclipse-ecal / ecal

📦 eCAL - enhanced Communication Abstraction Layer. A high performance publish-subscribe, client-server cross-plattform middleware.

https://ecal.io

Apache License 2.0

833 stars 174 forks source link

Auto approve action incorrectly marking files as public API. #1507

Open KerstinKeller opened 6 months ago

KerstinKeller commented 6 months ago

Problem Description

I changed some files in "contrib/mma/include/windows/network.h" which is not public eCAL API, yet the auto approve action refused to approve because it claims that it was.

Run echo "ERROR: Protected files have been changed:"
ERROR: Protected files have been changed:
contrib/mma/include/windows/network.h
Error: Process completed with exit code 1.

How to reproduce

How did you get eCAL?

I don't know

Environment

eCAL System Information

No response

FlorianReimold commented 6 months ago

Here are the files that cannot be auto-approved:

https://github.com/eclipse-ecal/ecal/blob/fb4b84041e35eb8ed9dc420a28b13c896f0db400/.github/workflows/pr-auto-approve.yml#L27-L37