[Ecore Editor] e4 support

[eclipse-ecp-bot]

| --- | --- | | Bugzilla Link | 490749 | | Status | NEW | | Importance | P1 normal | | Reported | Mar 31, 2016 02:37 EDT | | Modified | Sep 30, 2022 07:41 EDT | | See also | Gerrit change https://git.eclipse.org/r/84064 |

[eclipse-ecp-bot]

By Kirill Zotkin on Mar 31, 2016 02:53

Currently Generic Editor and it's subclasses only support 3.x part API.

It should be possible to use them as e4 parts.

[eclipse-ecp-bot]

By Eugen Neufeld on Mar 31, 2016 03:18

Hi Kirill,\ thanks for the report. \ We are happy to accept a contribution for this, as we probably won't have any resources to provide an e4 version for the ecore editor by ourselfs.

[eclipse-ecp-bot]

By Kirill Zotkin on Mar 31, 2016 03:54

Hi Eugen,

I were composing a message to you about an empty description of this bug.

We discussed with Jonas Helming (https://www.eclipse.org/forums/index.php?t=rview&goto=1728096#msg_1728096) yesterday that i will be contributing on it.

[eclipse-ecp-bot]

By Kirill Zotkin on Mar 31, 2016 04:46

Should GenericEditor remain 3.x EditorPart subclass and init's and createPartControl's methods contents are somehow with composition extracted into some kind of component and for e4 created another class?

[eclipse-ecp-bot]

By Kirill Zotkin on Mar 31, 2016 05:19

Or, maybe, GenericEditor will be used as 3.x API placeholder and applying part to application separated from its input interaction and rendering structure.

[eclipse-ecp-bot]

By Jonas Helming on Apr 04, 2016 07:36

Hi,

I do not get the second comment, but to the first: Yes, we need GenericEditor so still implement the 3.x interface. Components, which are shared between an 3.x Generic Editor and a E4GenereicEditor can be extracted...

[eclipse-ecp-bot]

By Kirill Zotkin on Oct 26, 2016 10:59

Created attachment 265059 (attachment deleted)\ Incomplete draft

Hello,

I delegated some resource interaction and treemasterdetail creation behaviour to extracted whatever called 'EditorSharedStrategy' components and reproduced existing e3 functionality. Also made RCP analog of AdapterFactory for RAP not using PlatformUI, but it plugs in with package version which shouldn't be so, I guess. But couldn't manage to get e4 generic editor working with my ECP provider which works in e4 RCP (wanted to create mock but thought it wouldn't help). The editor is just blank, but it looks like that it loads resource and renders well.\ Also, don't know what to do with the copyrights.

[eclipse-ecp-bot]

By Kirill Zotkin on Oct 27, 2016 03:37

Created attachment 265073 Updated incomplete draft

Made some updates fixing several mistakes I found looking at diff.

:notepad_spiral: 490749-1.patch

[eclipse-ecp-bot]

By Eugen Neufeld on Oct 27, 2016 05:33

Hi Kyrill, \ thank you for the work.\ Could you please commit your changes using gerrit? This way it is much easier to review and merge changes.

Cheers,\ Eugen

[eclipse-ecp-bot]

By Kirill Zotkin on Oct 28, 2016 01:35

https://git.eclipse.org/r/84064

But, as i said the implementation of E4GenericEditor is not completed.\ The editor part is blank. Maybe i missing something...\ Also, everything is not very polished.

[eclipse-ecp-bot]

Oct 28, 2016 02:18

New Gerrit change created: https://git.eclipse.org/r/84064

[eclipse-ecp-bot]

By Eugen Neufeld on Oct 28, 2016 04:45

Hi, \ Using gerrit you can continue fixing stuff and push it on the same gerrit id.

I will look into the code when I have time.

Thank you for your work.

Cheers,\ Eugen

[eclipse-ecp-bot]

By Kirill Zotkin on Oct 28, 2016 11:44

Hi,\ You are welcome. I'll be pushing significant & successful updates.

thanks for the help.\ Kyrill

[eclipse-ecp-bot]

Oct 19, 2018 13:48

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--\ The automated Eclipse Genie.

[eclipse-ecp-bot]

Oct 09, 2020 07:28

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--\ The automated Eclipse Genie.

[eclipse-ecp-bot]

Sep 30, 2022 07:41

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--\ The automated Eclipse Genie.