search

eclipse-edc / Connector

EDC core services including data plane and control plane
Apache License 2.0
284 stars 240 forks source link

CosmosDB tests are broken #774

Closed ndr-brt closed 2 years ago

ndr-brt commented 2 years ago

Seems like #721 make cosmos db integration tests fails, mainly because the PR brought the container object instantiation at class level and added a deleteAllItems function after every test execution, but this seems like it's not supported on the test instance: Partition key delete feature is disabled for this account. (ref: https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/runs/5356527290)

algattik commented 2 years ago

@ndr-brt also note that cleanup in CosmosContractDefinitionStoreIntegrationTest is not working properly because one test is changing the partition key. I'll fix that in my upcoming PR

ndr-brt commented 2 years ago

@algattik which one? I have my PR ready so I can add this fix right on.

algattik commented 2 years ago

https://github.com/agera-edc/DataSpaceConnector/pull/111

ndr-brt commented 2 years ago

Nice, so now they are working every time? Can I assign this issue to you then?

ndr-brt commented 2 years ago

Ok, just saw the comment on #360. will close this