These changes add flexibility to modify the base-href of the application according to need.
For example, when we try to deploy the edc-datadashboard to a Kubernetes cluster and implement an ingress route to access the services, it cannot load the asset files (css, js, images) properly. As a result, the angular app cannot be loaded properly.
In this PR, the build command in the Dockerfile has been modified, which uses a BASE_PATH argument. We can pass the BASE_PATH of choice at the time of image creation.
Also, the app-config.service.ts file is using the url 'assets/config/app.config.json' to get app config files.
In case, we are using a base-href different than root (‘/’) then this will fail to get the files. Therefore, we modified this file and prepared the url by adding the base-href with it.
Further notes
Applications that are using the Dockerfile of DataDashboard, should pass a BASE_PATH at the image creation time.
What this PR changes/adds
The Dockerfile and app-config.service.ts file.
Why it does that
These changes add flexibility to modify the
base-hrefof the application according to need. For example, when we try to deploy the edc-datadashboard to a Kubernetes cluster and implement an ingress route to access the services, it cannot load the asset files (css, js, images) properly. As a result, the angular app cannot be loaded properly.In this PR, the
buildcommand in theDockerfilehas been modified, which uses aBASE_PATHargument. We can pass theBASE_PATHof choice at the time of image creation.Also, the
app-config.service.tsfile is using the url 'assets/config/app.config.json' to get app config files. In case, we are using abase-hrefdifferent than root (‘/’) then this will fail to get the files. Therefore, we modified this file and prepared the url by adding thebase-hrefwith it.Further notes
Applications that are using the Dockerfile of DataDashboard, should pass a BASE_PATH at the image creation time.
Linked Issue(s)
Closes #224