search

eclipse-edc / IdentityHub

IdentityHub
Apache License 2.0
21 stars 25 forks source link

fix: generate VP use controller DID for setting additionalData #408

Closed thomasrutger closed 4 months ago

thomasrutger commented 4 months ago

What this PR changes/adds

Correctly uses the participant's DID instead of participantContextId when setting additionalData["controller"], setting it in PresentationCreatorRegistryImpl.createPresentation where the DID is already resolved (previously it was set in VerifiablePresentationServiceImpl.createPresentation).

Why it does that

Controller was set to participantContextId, which is not correct (e.g. caused problems with publicKeyId when generating a VP).

Further notes

Also changed tests (PresentationCreatorRegistryImplTest and VerifiablePresentationServiceImplTest) @paullatzelsperger

Linked Issue(s)

Closes #407

thomasrutger commented 4 months ago

Thanks @paullatzelsperger for giving me the opportunity to contribute!