eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
58 stars 167 forks source link

chore: Update EDC-Connector Version (0.2.0) and fix Tests #171

Closed janpmeyer closed 1 year ago

janpmeyer commented 1 year ago

What this PR changes/adds

Update EDC-Connector to 0.2.0 and fix broken Tests.

Why it does that

The version of the EDC-Connector should be up to date.

Further notes

Linked Issue(s)

Closes #170

Checklist

janpmeyer commented 1 year ago

I think only the UI Test is failing. In my opinion this need to be fixed in a different repository.

What do you guys think?

janpmeyer commented 1 year ago

Updated now also all versions in the gradle.properties. But the test (RUN MVD Docker incl. MVD UI) is failing while trying to download a docker image like also in other PRs then before.

Is this failing correlated to the Versions in the MVD or do you know some other reasons why the test is failing?

paullatzelsperger commented 1 year ago

Updated now also all versions in the gradle.properties. But the test (RUN MVD Docker incl. MVD UI) is failing while trying to download a docker image like also in other PRs then before.

Is this failing correlated to the Versions in the MVD or do you know some other reasons why the test is failing?

looking at this quickly, it could be that the paths are wrong: the dashboard gets checked out at MinimumViableDataspace/DataDashboard, but the docker compose file seems to expect it at MinimumViableDataspace/system-tests/DataDashboard

check .github/actions/gradle-setup/action.yml#L10

janpmeyer commented 1 year ago

I hope the creation of the HTTP-Body is ok for you. If you have any suggestions for improving, feel free to share.