eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
58 stars 167 forks source link

System Test appconfig has wrong management API URL configuration key #181

Closed Barium closed 3 months ago

Barium commented 1 year ago

It seems that the configuration for the companies in the resources folder, have not been updated to reflect the changes in the DataDashboard: https://github.com/eclipse-edc/DataDashboard/commit/550f6d0b557bf76b5ab7cf665d6c1a98cb156186

https://github.com/eclipse-edc/MinimumViableDataspace/blame/85311e57bdfb62a99cf7d2743fd328ea116bb2b6/system-tests/resources/appconfig/company1/app.config.json#L3

Basically the configuration key: "dataManagementApiUrl" should be renamed to "managementApiUrl" to reflect the changes in DataDashboard.

Is:

{
  "apiKey": "ApiKeyDefaultValue",
  "dataManagementApiUrl": "http://localhost:9192/api/management",
  "storageAccount": "company2assets",
  "storageExplorerLinkTemplate": "storageexplorer://v=1",
  "theme": "theme-2"
}

Should probably be:

{
  "apiKey": "ApiKeyDefaultValue",
  "managementApiUrl": "http://localhost:9192/api/management",
  "storageAccount": "company2assets",
  "storageExplorerLinkTemplate": "storageexplorer://v=1",
  "theme": "theme-2"
}
ndr-brt commented 1 year ago

Already addressed by #180

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 14 days with no activity.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 28 days with no activity.

github-actions[bot] commented 3 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.

github-actions[bot] commented 3 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.