eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
51 stars 160 forks source link

feat: upgrade MVD with DCP and Management Domains #270

Closed paullatzelsperger closed 2 months ago

paullatzelsperger commented 2 months ago

What this PR changes/adds

This PR brings a completely new iteration of the MinimumViableDataspace project by adding the following high-level features:

Why it does that

Keep up with current developments, improve the developer experience

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

_Please be sure to take a look at the contributing guidelines and our etiquette for pull requests._

paullatzelsperger commented 2 months ago

New files should have an updated header: 2023 --> 2024

those files have been there for quite some time, only in a different branch. but technically, they were in the repo, since the branch was in the upstream.

harnvo commented 2 months ago

I tried running the demo via IntelliJ and resulted in the following errors:

For Connector Consumer Corp I have:

SEVERE 2024-07-05T15:37:24.168402714 Error booting runtime: No setting found for key edc.mvd.credentials.path
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.credentials.path

For IdentityHub Consumer Corp I have:

SEVERE 2024-07-05T15:30:41.8848147 Error booting runtime: No setting found for key edc.mvd.participants.list.file
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.participants.list.file

For Provider Catalog Server I have:

SEVERE 2024-07-05T15:30:42.160374888 Error booting runtime: No setting found for key edc.mvd.credentials.path
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.credentials.path
paullatzelsperger commented 2 months ago

@harnvo something is fishy there. The catalog server and the connectors should not need the edc.mvd.credentials.path, and in turn the IdentityHub should not need the participants list. There is something weird going on.

In any event, I could not reproduce the errors you describe. If you're on Windows, be aware that paths may be a problem, and we don't officially support running this natively on Windows. We typically recommend using WSL.

harnvo commented 2 months ago

@paullatzelsperger I am using wsl2.

I later tried reproducing the problem in my Debian PC but everything works fine. It seems something's wrong on the WSL's side.

paullatzelsperger commented 2 months ago

@paullatzelsperger I am using wsl2.

I later tried reproducing the problem in my Debian PC but everything works fine. It seems something's wrong on the WSL's side.

this is just the run configurations, so nothing critical, but it still detracts from developer experience. if you are open to investigating platform-independent run configs, we'd welcome a PR

harnvo commented 2 months ago

this is just the run configurations, so nothing critical, but it still detracts from developer experience. if you are open to investigating platform-independent run configs, we'd welcome a PR

I would take a look when I am available.

The two PCs I have uses different network proxies, so it is also possible that one of the maven mirror did not update the package in-time.

Just curious: have eclipse-edc updated some packages recently? In this case waiting for a few days should solve the problem.

paullatzelsperger commented 2 months ago

Just curious: have eclipse-edc updated some packages recently? In this case waiting for a few days should solve the problem.

we publish snapshot builds on every PR merge, but you can force the refresh by either appending --refresh-dependencies to your gradle command, or by deleting your local gradle and maven caches.

harnvo commented 2 months ago

Update: I eventually find out what happened.

Somehow Intellij did not read the configuration in .run properly, and I have to manually edit the module config with UI to match the actual configuration file. After this everthing could work properly.

The problem would presist if I re-clone this repo. But I would stop the investigation since this is something wrong with Intellij (probably the IDE is somehow corrupted), and that I could not reproduce the problem in another windows PC (which has the same windows version, wsl version, Intellij version and the same proxy).

paullatzelsperger commented 2 months ago

@harnvo thanks a lot for investigating!