search

eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
51 stars 160 forks source link

chore: fix typo pom.xm -> pom.xml #297

Closed chlorochrule closed 1 month ago

chlorochrule commented 1 month ago

What this PR changes/adds

fixed a bit of typo

chlorochrule commented 1 month ago

TransferEndToEndTest looks to have been added recently 👀 Maybe unstable?

TransferEndToEndTest > transferData() FAILED java.lang.AssertionError: Expecting actual not to be null at org.eclipse.edc.demo.tests.transfer.TransferEndToEndTest.lambda$transferData$0(TransferEndToEndTest.java:75) https://github.com/eclipse-edc/MinimumViableDataspace/actions/runs/9978143759/job/27574368551?pr=297

paullatzelsperger commented 1 month ago

TransferEndToEndTest looks to have been added recently 👀 Maybe unstable?

yes, the test is fairly new. but nope, the error was introduced by an upstream change. once i have the fix ready, you'll need to rebase.

chlorochrule commented 1 month ago

understood, thanks!

paullatzelsperger commented 1 month ago

@chlorochrule good to rebase

paullatzelsperger commented 1 month ago

mmh, that test appears to be unstable indeed. not relevant for this PR though, so i'll merge it and address the flaky test in another PR

chlorochrule commented 1 month ago

hmm, thank you for merging!