eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
61 stars 169 forks source link

Flaky newman API tests #364

Closed paullatzelsperger closed 1 month ago

paullatzelsperger commented 1 month ago

Bug Report

Describe the Bug

Sometimes the Management API tests, using newman are failing due to timing issues.

Expected Behavior

consistent and stable tests

Observed Behavior

sometimes test fail because there is no retry and timeout mechanism with newman.

Detailed Description

newman executes all requests with a delay of 5 seconds between requests. if the processes running in the connectors haven't finished by then the request test fails with no option to retry.

Possible Implementation

there is no official way to retry a failed request, but there are hacky ways to implement that, for example this.

We'd have to find a way to re-use that retry code, otherwise we'd have to duplicate that in every request.

*I don't think it's worth the effort. I would simply allow the API tests to fail and log a warning, or remove them altogether