search

eclipse-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
61 stars 169 forks source link

feat: remove MvdScopeTransformer #384

Closed thomasrutger closed 2 weeks ago

thomasrutger commented 3 weeks ago

What this PR changes/adds

Remove MvdScopeTransformer that contained strange fallback behavior (from "dark times past") when an unrecognized scope credential type is encountered and use the default EdcScopeToCriterionTransformer instead.

Why it does that

This may be an artifact of dark times past, and could probably be removed

Further notes

@paullatzelsperger I did not add any tests, considering none of the mvd contains any tests, but I can add some if desired.

Linked Issue(s)

Closes #383

paullatzelsperger commented 3 weeks ago

I did not add any tests, considering none of the mvd contains any tests, but I can add some if desired.

this should be covered by the E2E tests we have in MVD

paullatzelsperger commented 2 weeks ago

the entire MvdScopeTransformer can be deleted

thomasrutger commented 2 weeks ago

the entire MvdScopeTransformer can be deleted

Done. I also updated the readme by moving 8.5 to 10.4 to indicate that the default EdcScopeToCriterionTransformer should probably not be used in a production scenario.