hemantxpatel commented 8 months ago

Bug Report

Describe the Bug

Any failure during S3 Tansfer causes subsequent requests to fail due to error: Connection pool shut down

A clear and concise description of the bug.

Expected Behavior

A clear and concise description of what you expected to happen.

If one S3 transfer fails, subsequent request should work fine.

Observed Behavior

A clear and concise description of what happened instead.

Steps to Reproduce

Steps to reproduce the behavior:

Initiate a transfer with an non existing destination bucket.

{
"@context": {
"odrl": "http://www.w3.org/ns/odrl/2/"
},
"assetId": "30",
"connectorAddress": "http://alice-controlplane:8084/api/v1/dsp",
"connectorId": "BPNL000000000001",
"contractId": "26615fbd-e474-40ce-aff4-a2da04b6e6ca",
"dataDestination": {
"type": "AmazonS3",
"keyName": "alice-test-document.txt",
"bucketName": "this-bucket-does-not-exist",
"region": "us-east-1",
"endpointOverride": "http://bob-minio:9000",
"accessKeyId": "bobawsclient",
"secretAccessKey": "bobawssecret"
},
"protocol": "dataspace-protocol-http"
}

Get Transfer State. It should be TERMINATED
Initiate another transfer this time with a bucket which already exists.
Get Transfer State. It should be TERMINATED.

Provider DataPlane Stack Trace:

DEBUG 2024-02-27T09:12:05.38690007 Transferring from AmazonS3 to AmazonS3.
SEVERE 2024-02-27T09:12:05.659398427 Failed to download the alice-test-document.txt object: Connection pool shut down
org.eclipse.edc.connector.dataplane.aws.s3.exceptions.S3DataSourceException: Connection pool shut down
    at org.eclipse.edc.connector.dataplane.aws.s3.S3DataSource$S3Part.openStream(S3DataSource.java:130)
    at org.eclipse.edc.connector.dataplane.aws.s3.S3DataSink.transferParts(S3DataSink.java:50)
    at org.eclipse.edc.connector.dataplane.util.sink.ParallelSink.lambda$transfer$3(ParallelSink.java:82)

Context Information

Add any other context about the problem here.

Used latest EDC version (0.6.0) but this bug existed in earlier version as well 0.5.3.

Detailed Description

If applicable, add screenshots and logs to help explain your problem.

Possible Implementation

You already know the root cause of the erroneous state and how to fix it? Feel free to share your thoughts.

github-actions[bot] commented 8 months ago

Thanks for your contribution :fire: We will take a look asap :rocket:

paullatzelsperger commented 7 months ago

un-assigned myself due to a lack of dev bandwidth

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 14 days with no activity.