eclipse-edc / Technology-Aws

Apache License 2.0
5 stars 15 forks source link

refactor: extract validator-data-address-s3 module #354

Closed ndr-brt closed 2 months ago

ndr-brt commented 2 months ago

What this PR changes/adds

Extracts validator-data-address-s3 module

Why it does that

modularity

Further notes

Linked Issue(s)

Closes #352

_Please be sure to take a look at the contributing guidelines and our etiquette for pull requests._

github-actions[bot] commented 2 months ago

Test Results

17 files  ±0  17 suites  ±0   26s :stopwatch: +17s 62 tests  - 2  62 :white_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0  64 runs   - 2  64 :white_check_mark:  - 2  0 :zzz: ±0  0 :x: ±0 

Results for commit 5ebbd155. ± Comparison against base commit 484fb469.

This pull request removes 19 and adds 17 tests. Note that renamed tests count towards both. ``` org.eclipse.edc.aws.s3.S3DestinationDataAddressValidatorExtensionTest ‑ initialize(S3DataAddressValidatorExtension, ServiceExtensionContext) org.eclipse.edc.aws.s3.validation.S3DestinationDataAddressValidatorTest ‑ should_fail_when_required_fields_are_missing() org.eclipse.edc.aws.s3.validation.S3DestinationDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid() org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_fail_when_both_object_name_and_prefix_are_missing() org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_fail_when_region_or_bucketName_is_missing() org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_name() org.eclipse.edc.aws.s3.validation.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_prefix() org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ [1] validBucketName, , validAccessKeyId, validSecretAccessKey org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ [2] , validRegion, validAccessKeyId, validSecretAccessKey org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_ShouldSucceedIfPropertiesAreValid() … ``` ``` org.eclipse.edc.aws.s3.validator.S3DataAddressValidatorExtensionTest ‑ initialize(S3DataAddressValidatorExtension, ServiceExtensionContext) org.eclipse.edc.aws.s3.validator.S3DestinationDataAddressValidatorTest ‑ should_fail_when_required_fields_are_missing() org.eclipse.edc.aws.s3.validator.S3DestinationDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid() org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_fail_when_both_object_name_and_prefix_are_missing() org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_fail_when_region_or_bucketName_is_missing() org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_name() org.eclipse.edc.aws.s3.validator.S3SourceDataAddressValidatorTest ‑ should_pass_when_data_address_is_valid_with_object_prefix() org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_shouldFail_whenValidatorFails() org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkFactoryTest ‑ validate_shouldSucceed_whenValidatorSucceeds() org.eclipse.edc.connector.dataplane.aws.s3.S3DataSinkTest ‑ [1] [org.eclipse.edc.connector.dataplane.spi.pipeline.InputStreamDataSource@1a67bde5] … ```

:recycle: This comment has been updated with latest results.