search

eclipse-edc / Technology-Aws

Apache License 2.0
5 stars 15 forks source link

feat: Modifies the AWS vault implementation to update existing secrets #379

Closed zub4t closed 1 month ago

zub4t commented 1 month ago

What this PR changes/adds

This PR updates the AWS Vault implementation to match the behavior of HashiCorp Vault. Previously, the store method in the AWS Vault implementation only created new secrets. With this update, the method now supports both creating and updating secrets, aligning it with the behavior of HashiCorp Vault.

Why it does that

This update is required because the recent addition of the Secrets Manager API introduces the capability to update secrets. As a result, the AWS Vault implementation must be updated to handle secret updates in addition to secret creation.

Linked Issue(s)

Closes #373

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (d177a98) to head (ee5e740). Report is 54 commits behind head on main.

Files Patch % Lines
.../eclipse/edc/vault/aws/AwsSecretsManagerVault.java 72.72% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ============================================ + Coverage 63.82% 65.47% +1.65% - Complexity 0 113 +113 ============================================ Files 26 28 +2 Lines 633 672 +39 Branches 30 32 +2 ============================================ + Hits 404 440 +36 + Misses 222 218 -4 - Partials 7 14 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ndr-brt commented 1 month ago

please fix the failing check and I will merge this