eclipse-edc / Technology-Aws

Apache License 2.0
5 stars 16 forks source link

fix(ci): set version before tests, publishing #402

Closed paullatzelsperger closed 2 months ago

paullatzelsperger commented 2 months ago

What this PR changes/adds

This PR adds a temporary fix to update the gradle/libs.version.toml version catalog before a version is published. Specifically, it passes the version string to verify.yaml, so that tests are executed using the given upstream EDC modules, and it updates gradle.properties, gradle/libs.versions.toml and DEPENDENCIES before the Maven artefacts are published.

In addition, the release job (release-tech-aws.yaml) only bumps the version if it was a "release" version (not a hotfix/bugfix or a snapshot).

Why it does that

employ a temporary fix until a restructuring of the release workflow can be implemented.

Further notes

I intentionally did not extract the sed command in a re-usable action, because it is a temporary fix anyway, and it is better if it sticks out like a sore thumb

Linked Issue(s)

Closes # <-- insert Issue number if one exists

_Please be sure to take a look at the contributing guidelines and our etiquette for pull requests._

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.47%. Comparing base (d177a98) to head (3e3c361). Report is 61 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #402 +/- ## ============================================ + Coverage 63.82% 65.47% +1.65% - Complexity 0 113 +113 ============================================ Files 26 28 +2 Lines 633 672 +39 Branches 30 32 +2 ============================================ + Hits 404 440 +36 + Misses 222 218 -4 - Partials 7 14 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.