search

eclipse-edc / Technology-Aws

Apache License 2.0
5 stars 15 forks source link

feat: Modifies the AWS vault implementation to update existing secrets (Backport) #407

Closed zub4t closed 3 weeks ago

zub4t commented 1 month ago

What this PR changes/adds

This PR updates the AWS Vault implementation to match the behavior of HashiCorp Vault. Previously, the store method in the AWS Vault implementation only created new secrets. With this update, the method now supports both creating and updating secrets, aligning it with the behavior of HashiCorp Vault.

Why it does that

This update is required because the recent addition of the Secrets Manage API introduces the capability to update secrets. As a result, the AWS Vault implementation must be updated to handle secret updates in addition to secret creation.

Further Notes

This is a backport from PR

rafaelmag110 commented 1 month ago

As mentioned in this discussion https://github.com/eclipse-tractusx/tractusx-edc/discussions/1496

paullatzelsperger commented 1 month ago

just curious: was this cherry-picked or backported?

zub4t commented 1 month ago

just curious: was this cherry-picked or backported?

It's cherry-pick. But since the target is an older version, I think the term backport can also be applied here 😅