search

eclipse-edc / Technology-Aws

Apache License 2.0
5 stars 17 forks source link

AwsSecretsManagerVault does not support endpiont overrides #486

Open chlorochrule opened 17 hours ago

chlorochrule commented 17 hours ago

Feature Request

AwsSecretsManagerVaultExtension do not support to override AWS endpoint. I think the option to override AWS endpoint of SecretsManagerClient makes development easier and provides flexibility.

Which Areas Would Be Affected?

Local development, CI, AWS-compatible services: Emulators like localstack are often used in AWS development. However, they require endpoint overrides.

Why Is the Feature Desired?

As mentioned above

Solution Proposal

I already implemented https://github.com/eclipse-edc/Technology-Aws/pull/485 This solution follows S3CoreExtension's implementation

https://github.com/eclipse-edc/Technology-Aws/blob/c43e0bb7c0161812fdf32b90c0c59b38869beab3/extensions/common/aws/aws-s3-core/src/main/java/org/eclipse/edc/aws/s3/S3CoreExtension.java#L45 https://github.com/eclipse-edc/Technology-Aws/blob/c43e0bb7c0161812fdf32b90c0c59b38869beab3/extensions/common/aws/aws-s3-core/src/main/java/org/eclipse/edc/aws/s3/S3CoreExtension.java#L61-L64

github-actions[bot] commented 17 hours ago

Thanks for your contribution :fire: We will take a look asap :rocket: