search

eclipse-edc / Technology-Gcp

Apache License 2.0
3 stars 6 forks source link

fix: compile errors after EDC token refactor #105

Closed paullatzelsperger closed 7 months ago

paullatzelsperger commented 7 months ago

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

github-actions[bot] commented 7 months ago

Test Results

59 tests  +25   59 :white_check_mark: +25   8s :stopwatch: +4s 10 suites + 4    0 :zzz: ± 0  10 files   + 4    0 :x: ± 0 

Results for commit 17d03cfd. ± Comparison against base commit 2a7acbd6.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2a7acbd) 63.71% compared to head (17d03cf) 63.52%.

Files Patch % Lines
.../edc/vault/gcp/GcpSecretManagerVaultExtension.java 66.66% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================== - Coverage 63.71% 63.52% -0.19% ========================================== Files 24 24 Lines 598 595 -3 Branches 30 30 ========================================== - Hits 381 378 -3 Misses 205 205 Partials 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.