search

eclipse-ee4j / angus-mail

Angus Mail
https://eclipse-ee4j.github.io/angus-mail
Other
56 stars 16 forks source link

package-info.class major version: 53 #83

Open jbescos opened 1 year ago

jbescos commented 1 year ago

package-info.class is supposed to have the major version 52

This is a known issue in other projects too: https://github.com/jakartaee/mail-api/issues/660 https://github.com/eclipse-ee4j/parsson/issues/73

aalmiray commented 1 year ago

It's not just package-info.class, there are others

$ jarviz bytecode show --gav org.eclipse.angus:angus-mail:2.0.1
Unversioned classes. Bytecode version: 52 total: 203
Unversioned classes. Bytecode version: 53 total: 12

These are the classes with bytecode version 53:

Unversioned classes. Bytecode version: 53 total: 12
org.eclipse.angus.mail.util.logging.package-info
org.eclipse.angus.mail.util.package-info
org.eclipse.angus.mail.imap.protocol.package-info
org.eclipse.angus.mail.imap.package-info
org.eclipse.angus.mail.iap.package-info
org.eclipse.angus.mail.handlers.package-info
org.eclipse.angus.mail.pop3.package-info
org.eclipse.angus.mail.smtp.package-info
org.eclipse.angus.mail.auth.package-info
org.eclipse.angus.mail.nativeimage.AngusMailFeature
org.eclipse.angus.mail.package-info
module-info

All of them should be inside /META-INFO/versions/9. Take note of org.eclipse.angus.mail.nativeimage.AngusMailFeature.

lukasj commented 1 year ago

fixed by #84

aalmiray commented 1 year ago

In a way it's fixed, yes. Then again classes compiled with bytecode 53 should be placed under META-INF/versions/9 while the rest of the codebase remains with bytecode 52. The JAR file should also be marked as a Multi Release JAR with a Multi-Release: true attribute in its manifest.

lukasj commented 1 year ago

Ah, right missed that piece