eclipse-ee4j / cargotracker

The project demonstrates how you can develop applications with Jakarta EE using widely adopted architectural best practices like Domain-Driven Design (DDD).
https://eclipse-ee4j.github.io/cargotracker/
MIT License
343 stars 142 forks source link

GlassFish support #282

Closed OndroMih closed 1 year ago

OndroMih commented 1 year ago

An alternative to https://github.com/eclipse-ee4j/cargotracker/pull/273 with a connector from the Arquillian project.

However, there are a few drawbacks:

m-reza-rahman commented 1 year ago

These look like a reasonable set of changes I could move forward to merge. What is causing the draft status? Are the changes ready for me to test or is there some other work left to finalize the PR?

OndroMih commented 1 year ago

These look like a reasonable set of changes I could move forward to merge. What is causing the draft status? Are the changes ready for me to test or is there some other work left to finalize the PR?

I raised the PR in draft because I prefer to merge https://github.com/eclipse-ee4j/cargotracker/pull/273 because of the reasons stated in the description.

But since you suggested to use this PR instead, I'll remove the draft status now and close #273

m-reza-rahman commented 1 year ago

I'll look to test and merge this. There may be some delay as I am currently on vacation. Hopefully there is no hurry?

OndroMih commented 1 year ago

There's no hurry at all. Take your time and enjoy your vacation!

m-reza-rahman commented 1 year ago

I've briefly tested this and it looks fine. @ojuschugh1 will also give it a spin. Then it can be merged.

ojuschugh1 commented 1 year ago

@m-reza-rahman I have tested it via command line and vs code(debugged and tested) for Glassfish and Payara. It is working fine. I have tested the batch job as well, it is also working properly. A total of 29/29 test cases passed without any error.

m-reza-rahman commented 1 year ago

Great. I’ll merge this as soon I have bandwidth to update all the associated documentation on the wiki and website.