Closed karianna closed 6 years ago
I agree with this change (I feel I should say something when my name is involved...)
@lukasj Thanks and apologies for not mentioning you directly so you could take a look!
@m0mus It's already there?
Cheers, Martijn
On 14 May 2018 at 16:23, Dmitry Kornilov notifications@github.com wrote:
@m0mus approved this pull request.
It looks good to me in general. I have one suggestion though. What about adding PMC mailing list email address to developer section?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse-ee4j/ee4j/pull/21#pullrequestreview-119884390, or mute the thread https://github.com/notifications/unsubscribe-auth/AALCaI93X6h62a7J6K937E6G0mbDzZ3Sks5tyaFegaJpZM4T9q48 .
@mkarg Given that IntelliJ dominates the IDE space for developers and that the target dir is created by executing Maven, this is probably OK?
I agree with @mkarg regarding .gitignore. I must admit, though, that I usually put IDE artifacts in the repository .gitignore to avoid lazy devs committing these artifacts by accident, so I am fine with keeping them.
2 v 1 :-), I'll remove it :-)
@karianna Thanks for removing it. Independend of any current market shares we should be fair and not support any particular product.
@karianna I didn't understand what you mean. Email address is not in the developer section. I suggested to add it, like this:
<email>jakarta.ee-community@eclipse.org</email>
or
<email>ee4j-pmc@eclipse.org</email>
@m0mus Gotcha - OK added.
Can this be merged now?
Closes #19 and updates #12