Backport to 3.0.x: Succeed TriggerControllerFuture.cancel when inner future is done

eclipse-ee4j / glassfish-concurro

Eclipse Concurrō project

https://projects.eclipse.org/projects/ee4j.glassfish

Other

15 stars 19 forks source link

Backport to 3.0.x: Succeed TriggerControllerFuture.cancel when inner future is done #92

Closed emmartins closed 1 month ago

emmartins commented 1 month ago

This is a backport of

Issue: https://github.com/eclipse-ee4j/glassfish-concurro/issues/87
Original master branch PR: https://github.com/eclipse-ee4j/glassfish-concurro/pull/68 (targeting 3.1.0)

The inner future (currentFuture) is used for repeating execution and its state is set to NORMAL/[Completed normally] after each cycle. The TriggerControllerFuture.cancel should return true even if this inner future is done.

pzygielo commented 1 month ago

What does it mean: FISH-6556?

OndroMih commented 1 month ago

What does it mean: FISH-6556?

I think it was some internal @aubi's task under which he contributed the original PR master, targeting 3.1.0. This is a backport of that PR to 3.0.x. I'll update the title accordingly.