search

eclipse-ee4j / glassfish-hk2

Dynamic dependency injection framework
https://eclipse-ee4j.github.io/glassfish-hk2
Other
83 stars 55 forks source link

Add OSGi Exports to HK2-Extras #1030

Closed Pandrex247 closed 1 month ago

Pandrex247 commented 3 months ago

Adds exports to the HK2-Extras module. The subtle change to the bundle plugin config applied in https://github.com/eclipse-ee4j/glassfish-hk2/pull/899 which fixed the global config by making it no longer ignore the instruction to not export anything means that without an override this module doesn't export anything. I'd argue it should be exporting stuff, as things can depend on it.

I've limited the exports to anything not in an "internal" package.

dmatej commented 2 months ago

I am quite sure #899 did not bring this change. https://github.com/eclipse-ee4j/glassfish-hk2/pull/899/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L261

I see it already in the beginning of 2022 and HK2 3.0.4. I have to admit that it smells bad ... does HK2 still use osgi.bundle files? Answer: yes, it does. And hk2-extras doesn't have it. Perhaps it would be good to make the bigger change ... as we did it in GlassFish already. Felix is quite good now and can do these things automatically.

dmatej commented 1 month ago

Oh, I forgot this is already here and I merged #1058 now, which is duplicit. I have to come back to this theme and make similar change we did in GlassFish - there Felix does most of this work better by default.