eclipse-ee4j / glassfish-hk2

Dynamic dependency injection framework
https://eclipse-ee4j.github.io/glassfish-hk2
Other
83 stars 55 forks source link

Include jakarta.annotation-api in BOM #1035

Closed pzygielo closed 2 months ago

dmatej commented 2 months ago

However Annotation 3.0 is for Jakarta EE 11, right? Then it should go rather to 4.0.0-prepare branch. Or we could merge that branch to master and create 3.x branch from the last commit before.

pzygielo commented 2 months ago

However Annotation 3.0 is for Jakarta EE 11, right?

Hmmm... This change in BOM only follows what is set in parent already.

Then it should go rather to 4.0.0-prepare branch. Or we could merge that branch to master and create 3.x branch from the last commit before.

Perhaps preparation could be finalized and merged to master.

create 3.x branch from the last commit before

This will not work then as the said annotation-api is bumped in master already. But some commit before, like edb7a0b0 could do.