bean-validator is still needed?

eclipse-ee4j / glassfish-hk2

Dynamic dependency injection framework

https://eclipse-ee4j.github.io/glassfish-hk2

Other

85 stars 57 forks source link

bean-validator is still needed? #34

Open glassfishrobot opened 8 years ago

glassfishrobot commented 8 years ago

bean-validator bundles hibernate-validator v5.1.2.Final within itself by extracting its source. hibernate-validator is already OSGI'ed, so if the motivation behind this is having an OSGI'ed bundle, why do you need this process? It has downsides like:

having old hibernate-validator dependency repackaged under another maven GAV, makes it harder to upgrade.
bean-validator drags along validation-api and jboss-logging artifacts also so they get re-bundled inside bean-validator? this is not a declarative approach to have a transitive dependency. If the aim is also having an OSGI'ed bundle, the aforementioned artifacts are already OSGI'ed.

glassfishrobot commented 6 years ago

Issue Imported From: https://github.com/javaee/hk2/issues/33
Original Issue Raised By:@mulderbaba
Original Issue Assigned To: Unassigned

glassfishrobot commented 8 years ago

@mtau11 Commented You're correct, at this point it should not be needed. OSGi does present some issues around the use of ServiceLoader which will need to be addressed when GlassFish consumes this new version. Created #34

glassfishrobot commented 8 years ago

@mulderbaba Commented Thanks @mtau11, I guess this will fix the NoClassDefFoundError that we get on WriteableView class under payara codebase.

glassfishrobot commented 8 years ago

@mtau11 Commented Yes, the static initializer in WriteableView was assuming javax.validation and hibernate-validator were using the same classloader, which will not longer be the case.

glassfishrobot commented 7 years ago

@mulderbaba Commented @mtau11 while consuming this hk2 version within glassfish, the ServiceLoader class cannot load org.hibernate.validator.internal.cdi.ValidationExtension class and gives a NoClassDefFoundError. Did you experience the same problems while handling #34 ?

glassfishrobot commented 7 years ago

@mtau11 Commented The ServiceLoader is delegating to an OSGi classloader. The portable extension jar does not have the OSGi manifest entries that are needed for GlassFish's classloader to load it. I believe they were looking at adding the appropriate OSGi manifest entries as a step in the GlassFish build.

glassfishrobot commented 7 years ago

@mulderbaba Commented @mtau11 I OSGI'fied hibernate-validator-cdi.jar and added necessary manifest entries inside it with bnd but that didn't help, probably need more investigation.